Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spanner): regenerate proto files and fix tests #10242

Merged

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented May 21, 2024

This PR does the following,

  1. Update proto generated files using latest protoc version.
  2. PR chore: prep for switching golint -> go vet #10223 modified the integration test for proto columns that led to test failures spanner: TestIntegration_BasicTypes_ProtoColumns failed #10236 (comment). The modification was done because go vet was throwing some errors as follows
./integration_test.go:2314:57: literal copies lock value from singerProtoMessage: cloud.google.com/go/spanner/testdata/protos.SingerInfo contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
./integration_test.go:2316:81: literal copies lock value from singerProtoMessage: cloud.google.com/go/spanner/testdata/protos.SingerInfo contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
./integration_test.go:2336:50: literal copies lock value from singerProtoMessage: cloud.google.com/go/spanner/testdata/protos.SingerInfo contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
./integration_test.go:2337:54: literal copies lock value from singerProtoMessage: cloud.google.com/go/spanner/testdata/protos.SingerInfo contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
./integration_test.go:2339:61: literal copies lock value from singerProtoMessage: cloud.google.com/go/spanner/testdata/protos.SingerInfo contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
./integration_test.go:2342:57: literal copies lock value from singerProtoMessage: cloud.google.com/go/spanner/testdata/protos.SingerInfo contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex

This PR has changes to fix the test failure and avoid go vet issue.

Fixes #10236

@harshachinta harshachinta requested review from a team as code owners May 21, 2024 09:43
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label May 21, 2024
@harshachinta harshachinta requested a review from rahul2393 May 21, 2024 11:49
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 21, 2024
@harshachinta harshachinta enabled auto-merge (squash) May 22, 2024 04:43
@harshachinta harshachinta merged commit fd4cfc2 into googleapis:main May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: TestIntegration_BasicTypes_ProtoColumns failed
3 participants