spanner: third party dependency exception for github.com/stretchr/testify

[noahdietz]

Module: spanner
Usage(s): spanner/integration_test.go

For the time being, it will be exempt from the third party dep check, but please do one of the following:

A. Remove the dependency by switching to a package own directly by Google, handwriting necessary functionality, or using stdlib
B. Justify the exception and ack the risks, maintaining the exception indefinitely

[rahul2393]

Used in tests only.

[egonelbre]

I don't have any concerns with testify package personally, but in this case the dependency removal is trivial. i.e.

google-cloud-go/spanner/integration_test.go

Line 2254 in 7bf4904

require.NoError(t, err)

// replace
require.NoError(t, err)

// with
if err != nil {
    t.Errorf("Apply returns error %v, want nil", err)
}

EDIT: just realized that it's also used via mockery.

[noahdietz]

Awesome, thank you @egonelbre

[noahdietz]

Need to remove the exemption now, oops