Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: TestIntegration_HashesOnUpload failed #7194

Closed
flaky-bot bot opened this issue Dec 28, 2022 · 0 comments · Fixed by #7195
Closed

storage: TestIntegration_HashesOnUpload failed #7194

flaky-bot bot opened this issue Dec 28, 2022 · 0 comments · Fixed by #7195
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Dec 28, 2022

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.

commit: a7720e4
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:2706: write with bad CRC32c: want error, got nil
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 28, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Dec 28, 2022
tritone added a commit to tritone/google-cloud-go that referenced this issue Dec 28, 2022
@tritone
chore(storage): fix checksum for grpc simple write
d5189d6 
In googleapis#7193 I moved the checksum logic to send on the request that
initiates the upload, but I inadvertently removed sending the
checksum for one-shot uploads. This PR restores the checksum
logic for simple uploads.

Fixes googleapis#7194
@tritone tritone mentioned this issue Dec 28, 2022
Merged
tritone added a commit that referenced this issue Dec 28, 2022
@tritone
chore(storage): fix checksum for grpc simple write (#7195)
3592917 
In #7193 I moved the checksum logic to send on the request that
initiates the upload, but I inadvertently removed sending the
checksum for one-shot uploads. This PR restores the checksum
logic for simple uploads.

Fixes #7194
This was referenced Jun 15, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(storage): fix checksum for grpc simple write tritone/google-cloud-go
1 participant
@tritone