Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: many tests failed #10338

Closed
flaky-bot bot opened this issue Jun 5, 2024 · 1 comment · Fixed by #10339
Closed

storage: many tests failed #10338

flaky-bot bot opened this issue Jun 5, 2024 · 1 comment · Fixed by #10339
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 5, 2024

Many tests failed at the same time in this package.

  • I will close this issue when there are no more failures in this package and
    there is at least one pass.
  • No new issues will be filed for this package until this issue is closed.
  • If there are already issues for individual test cases, I will close them when
    the corresponding test passes. You can close them earlier, if you prefer, and
    I won't reopen them while this issue is still open.

Here are the tests that failed:

commit: b92406c
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 5, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 5, 2024
@tritone
Copy link
Contributor

tritone commented Jun 5, 2024

Looks like a change to how test bucket UUIDs is generated is needed.

    --- PASS: TestIntegration_NonexistentBucket/http (0.23s)
    --- FAIL: TestIntegration_NonexistentBucket/grpc (0.00s)
panic: Short space called New more than 99 times. Ran out of IDs. [recovered]
	panic: Short space called New more than 99 times. Ran out of IDs.```

tritone added a commit to tritone/google-cloud-go that referenced this issue Jun 5, 2024
@tritone
test(storage): use long uidSpace for buckets
c6564a1 
Short uids are too short for the number of tests we have now.
Use a long space (6 digits instead of 2). Tested locally and
ensured that bucket names are still within GCS limits (63
chars max).

Fixes googleapis#10338
Fixes googleapis#10337
Fixes googleapis#10336
Fixes googleapis#10335
Fixes googleapis#10334
Fixes googleapis#10333
@tritone tritone mentioned this issue Jun 5, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 5, 2024
@tritone
test(storage): use long uidSpace for buckets (#10339)
fdb0958 
Short uids are too short for the number of tests we have now. Use a long space (6 digits instead of 2). Tested locally and ensured that bucket names are still within GCS limits (63 chars max).

Fixes #10338
Fixes #10337
Fixes #10336
Fixes #10335
Fixes #10334
Fixes #10333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(storage): use long uidSpace for buckets tritone/google-cloud-go
1 participant
@tritone