fix(bigquery): remove retry on FailedPrecondition (#10671)

googleapis · Aug 12, 2024 · ab9a961 · ab9a961
1 parent 0f25bf2
commit ab9a961
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/bigquery/storage_iterator.go b/bigquery/storage_iterator.go
@@ -289,7 +289,6 @@ func retryReadRows(bo gax.Backoff, err error) (time.Duration, bool) {
 	case codes.Aborted,
 		codes.Canceled,
 		codes.DeadlineExceeded,
-		codes.FailedPrecondition,
 		codes.Internal,
 		codes.Unavailable:
 		return bo.Pause(), true

diff --git a/bigquery/storage_iterator_test.go b/bigquery/storage_iterator_test.go
@@ -49,9 +49,17 @@ func TestStorageIteratorRetry(t *testing.T) {
 				status.Errorf(codes.Unavailable, "try 2"),
 				status.Errorf(codes.Canceled, "try 3"),
 				status.Errorf(codes.Internal, "try 4"),
+				status.Errorf(codes.Aborted, "try 5"),
 			},
 			wantFail: false,
 		},
+		{
+			desc: "expired session",
+			errors: []error{
+				status.Errorf(codes.FailedPrecondition, "read session expired"),
+			},
+			wantFail: true,
+		},
 		{
 			desc: "not enough permission",
 			errors: []error{