Skip to content

Commit

Permalink
fix(storage): disable allow non-default credentials flag (#11337)
Browse files Browse the repository at this point in the history
* fix(storage): disable allow non-default credentials flag

* skip test for direct connectivity
  • Loading branch information
frankyn authored Dec 20, 2024
1 parent 6ad383b commit 145ddf4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions storage/grpc_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ func defaultGRPCOptions() []option.ClientOption {
// Only enable DirectPath when the emulator is not being targeted.
defaults = append(defaults,
internaloption.EnableDirectPath(true),
internaloption.EnableDirectPathXds(),
internaloption.AllowNonDefaultServiceAccount(true))
internaloption.EnableDirectPathXds())
}

return defaults
Expand Down
1 change: 1 addition & 0 deletions storage/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ var readCases = []readCase{
// 3. DC not detected with dual region bucket in EUR4
// 4. DC not detected with regional bucket in EUROPE-WEST1
func TestIntegration_DetectDirectConnectivityInGCE(t *testing.T) {
t.Skip("Does not work in kokoro yet")
ctx := skipHTTP("grpc only test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, bucket string, prefix string, client *Client) {
h := testHelper{t}
Expand Down

0 comments on commit 145ddf4

Please sign in to comment.