Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): deflake decompressive transcoding test #14549

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 23, 2024

Use timeouts more appropriate for gRPC, specially after the gRPC timeout
scaling fixes.

Part of the work for #14543


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (9149a06) to head (6e7977f).
Report is 100 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14549   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files        2318     2318           
  Lines      206990   206982    -8     
=======================================
  Hits       193728   193728           
+ Misses      13262    13254    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review July 23, 2024 17:35
@coryan coryan requested review from a team as code owners July 23, 2024 17:35
Use timeouts more appropriate for gRPC, specially after the gRPC timeout
scaling fixes.
@coryan coryan force-pushed the test-storage-deflake-decompressive-transcoding-test branch from 7a5ddc6 to 6e7977f Compare July 24, 2024 02:16
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit c8a8f83 into googleapis:main Jul 24, 2024
67 checks passed
@coryan coryan deleted the test-storage-deflake-decompressive-transcoding-test branch July 24, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants