feat: create impersonated service credentials #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viacheslav-rostovtsev
force-pushed
the
dev/virost/impersonated_creds
branch
3 times, most recently
from
743091e to
2ed3089
Compare
dazuma
requested changes
Nov 20, 2024
viacheslav-rostovtsev
force-pushed
the
dev/virost/impersonated_creds
branch
from
ce48b35 to
29e3873
Compare
viacheslav-rostovtsev
added
the
do not merge
|
Do not merge: the case where the source credentials are wrapped in the Google::Auth::Credentials is not covered |
viacheslav-rostovtsev
removed
the
do not merge
dazuma
requested changes
Jan 8, 2025
lib/googleauth/credentials.rb
Outdated
| client: @client, | ||
| project_id: @project_id, | ||
| quota_project_id: @quota_project_id, | ||
| logger: @logger |
There was a problem hiding this comment.
I think this should be @client.logger?
There was a problem hiding this comment.
There was a giant copy paste error in credentials and I forgot to add tests. Fixed now
viacheslav-rostovtsev
force-pushed
the
dev/virost/impersonated_creds
branch
from
4398dfd to
360803e
Compare
dazuma
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: create impersonated service credentials
feat: add duplication mechanism to various credentials to support "re-scoping" them for IAM requests