Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pluggable auth support #995
feat: Pluggable auth support #995
Changes from 6 commits
63ad5e9
f36e5e8
28cfefc
4b1e956
d7f4980
7092170
5246463
62246d6
d0e4294
0ceda64
6618271
1f38c45
be1cfc9
97bd209
139bac9
33c7667
3894c25
9c233dc
72ae073
d51fd90
b0b9ad2
6712710
29ac755
1abed38
d276d52
c9d304d
ac6c360
c87b614
decb412
1c9b6db
564c3a0
a7efb54
1c08483
adc6779
889bf32
e9db21c
a94b68b
e1edbb6
74beba9
ac697a2
ca65d6b
ce79682
78b2f83
74afd44
9a4a518
d6ab6f0
ac27e4a
484d07f
d71587e
3d40268
8bfae0a
245b610
25b5446
34126ef
15d7a79
1e5a89a
f423446
e0b966a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too familiar with Python but what happens if there is no "version" field here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very familiar with python either. I came across this syntax to get a default value if the version is not present.
lookupValue = somedict.get(someKey, someDefaultValue)
May this can be used to simplify your code in the places where you are checking for presence first?
@renkelvin: We did this intentionally to distinguish whether it's a format issue or a content issue, so we can inform the customer to fix the output accordingly.