feat: distinguish transport and execution time timeouts #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Requests transport treat ``timeout`` stricly as a transport timeout, while the total allowed method execution time can be set with an optional ``max_allowed_time`` argument.
plamut
added
the
type: feature request
googlebot
added
the
cla: yes
busunkim96
reviewed
Jan 22, 2020
Co-Authored-By: Bu Sun Kim <[email protected]>
…h-library-python into iss-423-rework-timeout
busunkim96
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #423.
Towards https://github.com/googleapis/google-cloud-python/issues/10137
This PR makes a distinction between the Requests transport timeout, i.e. the
timeoutparameter, and the total allowed execution time for therequest()method, i.e. themax_allowed_timeargument. These two are not mixed together anymore.In other words, if
timeoutis passed in (set to, say, 60 seconds) and an underlying request takes longer, but the times between the bytes received by the socket are all under 60 seconds, theTimeoutGuardshould not kick in and cause a timeout error (the cause of Storage #10137).TimeoutGuardis only affected bymax_allowed_time, which isNoneby default, making the guard a no-op.