Add autorefresh lifetime for impersonated_redentials #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
approved these changes
Nov 12, 2018
takirala
referenced
this pull request
in d2iq-archive/dcos-commons
Dec 13, 2018
This PR contains the following updates: | Package | Update | Change | References | |---|---|---|---| | google-auth | minor | `==1.5.1` -> `==1.6.1` | [source](https://renovatebot.com/gh/GoogleCloudPlatform/google-auth-library-python) | --- ### Release Notes <details> <summary>GoogleCloudPlatform/google-auth-library-python</summary> ### [`v1.6.1`](https://renovatebot.com/gh/GoogleCloudPlatform/google-auth-library-python/blob/master/CHANGELOG.rst#v161) [Compare Source](https://renovatebot.com/gh/GoogleCloudPlatform/google-auth-library-python/compare/v1.6.0...v1.6.1) 11-12-2018 10:10 PST Implementation Changes \++++++++++++++++++++++ - Automatically refresh impersonated credentials (`#​304 <https://github.com/googleapis/google-auth-library-python/pull/304>`\_) ### [`v1.6.0`](https://renovatebot.com/gh/GoogleCloudPlatform/google-auth-library-python/blob/master/CHANGELOG.rst#v160) [Compare Source](https://renovatebot.com/gh/GoogleCloudPlatform/google-auth-library-python/compare/v1.5.1...v1.6.0) 11-09-2018 11:07 PST New Features \++++++++++++ - Add google.auth.impersonated_credentials (`#​299 <https://github.com/googleapis/google-auth-library-python/pull/299>`_) Documentation \+++++++++++++ - Update link to documentation for default credentials (`#​296 <https://github.com/googleapis/google-auth-library-python/pull/296>`\_) - Update github issue templates (`#​300 <https://github.com/googleapis/google-auth-library-python/pull/300>`\_) - Remove punctuation which becomes part of the url (`#​284 <https://github.com/googleapis/google-auth-library-python/pull/284>`\_) Internal / Testing Changes \++++++++++++++++++++++++++ - Update trampoline.sh (`#​302 <https://github.com/googleapis/google-auth-library-python/pull/302>`\_) - Enable static type checking with pytype (`#​298 <https://github.com/googleapis/google-auth-library-python/pull/298>`\_) - Make classifiers in setup.py an array. (`#​280 <https://github.com/googleapis/google-auth-library-python/pull/280>`\_) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#mesosphere/dcos-commons).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove logic that current does not
refreshcredentials iflifetime=parameter is set.After this change, if the
lifetime=is set, it only applies to the actual token returned for the impesonated credentials. If either thesource_credentialor ortarget_credentialexpires, a refresh will get called to regenerate a new one. If a user just wants a non-expiring access_token for the impersonated credentials, they can extract the access_token and.apply()headers.