chore: Made Compute Engine Metadata service exceptions more informative #1637
Conversation
Previously, the information about the original exceptions was omitted.
| attempt, | ||
| retry_count, | ||
| response.status, | ||
| raise exceptions.TransportError( |
There was a problem hiding this comment.
I think the retryable status code is expected in this case so I'm not sure a conversion to exception is the right thing and it makes the code a bit harder to understand.
(1) Can the customer set log level to an appropriate level to see these attempts? This is the best solution because it preserves the full history of retry attempts.
(2) If the code gets here, response is set and you can just use that to raise the error below. This would also catch the non-retryable error case.
| else: | ||
| break | ||
|
|
||
| except exceptions.TransportError as e: | ||
| last_exception = e |
There was a problem hiding this comment.
This is a good idea. Clear response here if you're following my suggestions.
| @@ -229,7 +231,7 @@ def get( | |||
| raise exceptions.TransportError( | |||
There was a problem hiding this comment.
Here we should consult last_exception and response to construct the right error:
(1) Non-retryable error encountered: response.status
(2) Ran out of retries: last_exception
(3) Ran out of retries: response.status
There was a problem hiding this comment.
Yes, this was the first iteration of the idea. It seems to me that converting response to an exception works just as well and simplifies the logic since only the last exception needs to be tracked. The logging etc does not change. Do you want us to change this?
| @@ -202,22 +202,24 @@ def get( | |||
|
|
|||
| backoff = ExponentialBackoff(total_attempts=retry_count) | |||
|
|
|||
| last_exception = None | |||
| for attempt in backoff: | |||
| try: | |||
| response = request(url=url, method="GET", headers=headers_to_use) | |||
There was a problem hiding this comment.
clear last_exception here if you're following my suggestions.
| ) | ||
| continue | ||
| else: | ||
| break |
There was a problem hiding this comment.
clear last_exception here if you follow my suggestions.
Previously, the information about the original exceptions was omitted.