Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding default parameters to updated interfaces #1622

Merged
merged 7 commits into from
Oct 30, 2024
Merged

fix: adding default parameters to updated interfaces #1622

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b4e4557
fix: adding default parameters to updated interfaces
TimurSadykov Oct 30, 2024
c650fc9
fix: adding default UD parameter to client
TimurSadykov Oct 30, 2024
95580d1
Merge branch 'main' into stim-unbreak
TimurSadykov Oct 30, 2024
f70e34b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 30, 2024
a816c4d
Merge branch 'stim-unbreak' of https://github.com/googleapis/google-a…
gcf-owl-bot[bot] Oct 30, 2024
eb9fdfb
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 30, 2024
b5c221d
Merge branch 'stim-unbreak' of https://github.com/googleapis/google-a…
gcf-owl-bot[bot] Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion google/auth/impersonated_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@


def _make_iam_token_request(
request, principal, headers, body, universe_domain, iam_endpoint_override=None
request,
principal,
headers,
body,
universe_domain=credentials.DEFAULT_UNIVERSE_DOMAIN,
iam_endpoint_override=None,
):
"""Makes a request to the Google Cloud IAM service for an access token.
Args:
Expand Down
2 changes: 1 addition & 1 deletion google/oauth2/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def call_iam_generate_id_token_endpoint(
signer_email,
audience,
access_token,
universe_domain,
universe_domain = credentials.DEFAULT_UNIVERSE_DOMAIN,
):
"""Call iam.generateIdToken endpoint to get ID token.

Expand Down