Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expiry in compute_engine.IDTokenCredentials #1327

Merged
merged 1 commit into from
Jun 9, 2023
Merged

fix: expiry in compute_engine.IDTokenCredentials #1327

merged 1 commit into from
Jun 9, 2023

Conversation

juzna
Copy link
Contributor

@juzna juzna commented Jun 8, 2023

fixes #1323

@google-cla
Copy link

google-cla bot commented Jun 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@clundin25 clundin25 marked this pull request as ready for review June 9, 2023 19:20
@clundin25 clundin25 requested review from a team as code owners June 9, 2023 19:20
@clundin25 clundin25 changed the title fix expiry in compute_engine.IDTokenCredentials fix: expiry in compute_engine.IDTokenCredentials Jun 9, 2023
@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2023
@clundin25
Copy link
Contributor

@juzna

Can you update the test case as well?

https://github.com/googleapis/google-auth-library-python/blob/main/tests/compute_engine/test_credentials.py#L773

@juzna
Copy link
Contributor Author

juzna commented Jun 9, 2023

Tests updated & commit ammended.

@clundin25 clundin25 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2023
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 9, 2023
@clundin25 clundin25 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 9, 2023
@clundin25
Copy link
Contributor

Thank you for your contribution !

@gcf-merge-on-green gcf-merge-on-green bot merged commit 56a6159 into googleapis:main Jun 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 9, 2023
@juzna juzna deleted the patch-1 branch June 9, 2023 21:52
@release-please release-please bot mentioned this pull request Jun 10, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 13, 2023
@release-please
chore(main): release 2.20.0 (#1328)
36bba13 
🤖 I have created a release *beep* *boop*
---


## [2.20.0](https://togithub.com/googleapis/google-auth-library-python/compare/v2.19.1...v2.20.0) (2023-06-12)


### Features

* Add public API load_credentials_from_dict ([#1326](https://togithub.com/googleapis/google-auth-library-python/issues/1326)) ([5467ad7](https://togithub.com/googleapis/google-auth-library-python/commit/5467ad75334ee0b5e23522679171cda5fd4edb8a))


### Bug Fixes

* Expiry in compute_engine.IDTokenCredentials ([#1327](https://togithub.com/googleapis/google-auth-library-python/issues/1327)) ([56a6159](https://togithub.com/googleapis/google-auth-library-python/commit/56a6159444467717f5a5e3c04aa678bd0a5881da)), closes [#1323](https://togithub.com/googleapis/google-auth-library-python/issues/1323)
* Expiry in impersonated_credentials.IDTokenCredentials ([#1330](https://togithub.com/googleapis/google-auth-library-python/issues/1330)) ([d1b887c](https://togithub.com/googleapis/google-auth-library-python/commit/d1b887c4bebbe4ad0df6d8f7eb6a6d50355a135d))
* Invalid `dev` version identifiers in `setup.py` ([#1322](https://togithub.com/googleapis/google-auth-library-python/issues/1322)) ([a9b8f12](https://togithub.com/googleapis/google-auth-library-python/commit/a9b8f12db0c3ff4f84939646ba0777d21e68f572)), closes [#1321](https://togithub.com/googleapis/google-auth-library-python/issues/1321)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25 clundin25 approved these changes

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Assignees

@arithmetic1728 arithmetic1728

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong timezones in compute_engine.IDTokenCredentials expiry
4 participants
@juzna @clundin25 @arithmetic1728 @yoshi-kokoro