Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix socket leak in impersonated_credentials #1123

Merged
merged 2 commits into from
Aug 29, 2022
Merged

fix: fix socket leak in impersonated_credentials #1123

merged 2 commits into from
Aug 29, 2022

Commits on Aug 26, 2022

  1. fix: Fix socket leak in impersonated_credentials 

    impersonated_credentials.Credentials.sign_bytes() created
a session that wasn't closed leaking a socket. This fixes
the issue by always closing the requests session after
a signing request is complete.

Fixes googleapis#1122
    @stewartmiles
    stewartmiles committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    2dcb6d3 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. chore: Refresh system test creds.

    @clundin25
    clundin25 committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    cec3af0 View commit details
    Browse the repository at this point in the history