feat: allow ServiceAccountJwtAccessCredentials to sign scopes #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
shinfan
approved these changes
Jun 12, 2021
This was referenced Jun 14, 2021
dwsupplee
suggested changes
Jun 22, 2021
| return null; | ||
| } | ||
|
|
||
| if (!empty($audience) && !empty($scope)) { | ||
| throw new UnexpectedValueException( |
There was a problem hiding this comment.
Suggested change
| throw new UnexpectedValueException( | |
| throw new \UnexpectedValueException( |
Would we be able to document this being thrown? Wondering if we need a test for this as well.
There was a problem hiding this comment.
Good catch and yes, I added a test!
I'm happy to add @throws. In this library in general (not that it's the right thing to do), we haven't been documenting thrown exceptions.
There was a problem hiding this comment.
I trust your judgement 👍
| if (!(is_null($this->getScope()))) { | ||
| $assertion['scope'] = $this->getScope(); | ||
| } | ||
|
|
||
| if (empty($assertion['scope']) && empty($assertion['aud'])) { | ||
| throw new \DomainException('one of scope or aud should not be null'); |
There was a problem hiding this comment.
Do we need a test to exercise this?
There was a problem hiding this comment.
good point, added!
Co-authored-by: David Supplee <[email protected]>
dwsupplee
approved these changes
Jun 22, 2021
gcf-merge-on-green bot
pushed a commit
to googleapis/gax-php
that referenced
this pull request
Aug 20, 2021
**TODO** - [x] Merge and tag googleapis/google-auth-library-php#341 - [x] Update minimum `google/auth` version in `composer.json` to the new tag ([v1.16.0](https://github.com/googleapis/google-auth-library-php/releases/tag/v1.16.0)) - [x] Add `'useJwtAccessWithScopes' => false` to `gapic-generator-php` for DIREGAPIC APIs (done in googleapis/gapic-generator-php#309) - [x] Generate a new [Gapic Compute client](https://github.com/googleapis/google-cloud-php/tree/master/Compute) with the changes in googleapis/gapic-generator-php#309 _Note_: These steps are now optional because Compute does not need the exclusion for Self-Signed JWTs with Scopes - [ ] Merge googleapis/google-cloud-php#4199 - [ ] Tag a new version of `google/cloud-compute` - [ ] Merge _this PR_ - [ ] Tag a new version of _this library_ (`google/gax`) - [ ] Update [Gapic Compute client](https://github.com/googleapis/google-cloud-php/tree/master/Compute) requires [the latest tag of google/gax](https://github.com/googleapis/google-cloud-php/blob/master/Compute/composer.json#L8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://google.aip.dev/auth/4111#scope-vs-audience
cc @shinfan