fix: add support for php 8.4, remove implicit nullable (#591)

googleapis · Dec 4, 2024 · 3e1061b · 3e1061b
1 parent ba137b2
commit 3e1061b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -10,7 +10,7 @@ jobs:
     test:
         strategy:
             matrix:
-                php: [ "8.1", "8.2", "8.3" ]
+                php: [ "8.1", "8.2", "8.3", "8.4" ]
                 os: [ ubuntu-latest ]
                 include:
                   - os: windows-latest

diff --git a/src/Credentials/UserRefreshCredentials.php b/src/Credentials/UserRefreshCredentials.php
@@ -75,7 +75,7 @@ class UserRefreshCredentials extends CredentialsLoader implements GetQuotaProjec
     public function __construct(
         $scope,
         $jsonKey,
-        string $targetAudience = null
+        ?string $targetAudience = null
     ) {
         if (is_string($jsonKey)) {
             if (!file_exists($jsonKey)) {

diff --git a/tests/bootstrap.php b/tests/bootstrap.php
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-error_reporting(E_ALL | E_STRICT);
+error_reporting(E_ALL);
 require dirname(__DIR__) . '/vendor/autoload.php';
 date_default_timezone_set('UTC');