-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sign method to JWT #375
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ | |
|
||
import assert from 'assert'; | ||
import child_process from 'child_process'; | ||
import crypto from 'crypto'; | ||
import fs from 'fs'; | ||
import {BASE_PATH, HEADER_NAME, HOST_ADDRESS} from 'gcp-metadata'; | ||
import nock from 'nock'; | ||
|
@@ -45,6 +46,7 @@ const privateJSON = require('../../test/fixtures/private.json'); | |
const private2JSON = require('../../test/fixtures/private2.json'); | ||
const refreshJSON = require('../../test/fixtures/refresh.json'); | ||
const fixedProjectId = 'my-awesome-project'; | ||
const privateKey = fs.readFileSync('./test/fixtures/private.pem', 'utf-8'); | ||
|
||
let auth: GoogleAuth; | ||
let sandbox: sinon.SinonSandbox|undefined; | ||
|
@@ -1325,3 +1327,38 @@ it('should make the request', async () => { | |
scopes.forEach(s => s.done()); | ||
assert.deepEqual(res.data, data); | ||
}); | ||
|
||
it('sign should use the private key for JWT clients', async () => { | ||
const data = 'abc123'; | ||
const auth = new GoogleAuth({ | ||
credentials: | ||
{client_email: '[email protected]', private_key: privateKey} | ||
}); | ||
const value = await auth.sign(data); | ||
const sign = crypto.createSign('RSA-SHA256'); | ||
sign.update(data); | ||
const computed = sign.sign(privateKey, 'base64'); | ||
assert.equal(value, computed); | ||
}); | ||
|
||
it('sign should hit the IAM endpoint if no private_key is available', | ||
async () => { | ||
mockEnvVar('GCLOUD_PROJECT', fixedProjectId); | ||
const {auth, scopes} = mockGCE(); | ||
const email = '[email protected]'; | ||
const iamUri = `https://iam.googleapis.com`; | ||
const iamPath = | ||
`/v1/projects/${fixedProjectId}/serviceAccounts/${email}:signBlob`; | ||
const signature = 'erutangis'; | ||
const data = 'abc123'; | ||
scopes.push( | ||
nock(iamUri).post(iamPath).reply(200, {signature}), | ||
nock(host) | ||
.get(svcAccountPath) | ||
.reply( | ||
200, {default: {email, private_key: privateKey}}, | ||
{'Metadata-Flavor': 'Google'})); | ||
const value = await auth.sign(data); | ||
scopes.forEach(x => x.done()); | ||
assert.equal(value, signature); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.