Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Log Error On Error #1760

Merged
merged 3 commits into from
Feb 26, 2024
Merged

test: Log Error On Error #1760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff13e27
test: Log Error On Error
d-goog Feb 26, 2024
8dd1e35
chore: type fix
d-goog Feb 26, 2024
a5df3bf
refactor: revert accidental changes from another branch
d-goog Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions samples/test/externalclient.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ describe('samples for external-account', () => {
},
});
// Confirm expected script output.
assert.match(output, /DNS Info:/);
assert.match(output, /DNS Info:/, output);
});

it('should sign the blobs with IAM credentials API', async () => {
Expand Down Expand Up @@ -389,7 +389,7 @@ describe('samples for external-account', () => {
},
});
// Confirm expected script output.
assert.match(output, /DNS Info:/);
assert.match(output, /DNS Info:/, output);
});

it('should acquire ADC for AWS creds', async () => {
Expand Down Expand Up @@ -427,7 +427,7 @@ describe('samples for external-account', () => {
},
});
// Confirm expected script output.
assert.match(output, /DNS Info:/);
assert.match(output, /DNS Info:/, output);
});

it('should acquire ADC for PluggableAuth creds', async () => {
Expand Down Expand Up @@ -474,7 +474,7 @@ describe('samples for external-account', () => {
},
});
// Confirm expected script output.
assert.match(output, /DNS Info:/);
assert.match(output, /DNS Info:/, output);
});

it('should acquire access token with service account impersonation options', async () => {
Expand Down
2 changes: 1 addition & 1 deletion src/auth/oauth2client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,7 @@ export class OAuth2Client extends AuthClient {

protected async getRequestMetadataAsync(
// eslint-disable-next-line @typescript-eslint/no-unused-vars
url?: string | null
url?: string | URL | null
): Promise<RequestMetadataResponse> {
const thisCreds = this.credentials;
if (
Expand Down
Loading