-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AWS Session Token to Metadata Requests #1363
Conversation
Warning: This pull request is touching the following templated files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! I just have a couple of suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues from my end. Thanks for putting this together!
"img.shields.io", | ||
"http://169.254.169.254/latest/api/token%22" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"img.shields.io", | |
"http://169.254.169.254/latest/api/token%22" | |
"img.shields.io" |
This file is generated, so removing this from ignore -- I don't think we should need it unless we link to this URL somewhere in the ref docs.
@sai-sunder-s this looks good to me, appologies for the slow review. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #194738780 🦕