Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AWS Session Token to Metadata Requests #1363

Merged
merged 7 commits into from
Feb 22, 2022

Conversation

sai-sunder-s
Copy link
Contributor

@sai-sunder-s sai-sunder-s commented Feb 12, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #194738780 🦕

@sai-sunder-s sai-sunder-s requested review from a team as code owners February 12, 2022 02:19
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! I just have a couple of suggestions.

src/auth/awsclient.ts Outdated Show resolved Hide resolved
src/auth/awsclient.ts Outdated Show resolved Hide resolved
src/auth/awsclient.ts Show resolved Hide resolved
@lsirac lsirac self-requested a review February 14, 2022 23:10
Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues from my end. Thanks for putting this together!

@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 21, 2022
Comment on lines +6 to +7
"img.shields.io",
"http://169.254.169.254/latest/api/token%22"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"img.shields.io",
"http://169.254.169.254/latest/api/token%22"
"img.shields.io"

This file is generated, so removing this from ignore -- I don't think we should need it unless we link to this URL somewhere in the ref docs.

@bcoe
Copy link
Contributor

bcoe commented Feb 21, 2022

@sai-sunder-s this looks good to me, appologies for the slow review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants