fix: Support 404 When GaxiosError != GaxiosError (#1707)

* fix: Support 404 When GaxiosError != GaxiosError * fix: optionalize * refactor: Even more robust for `GaxiosError` != `GaxiosError` Older versions of gaxios may not have `.status`, but only `.response.status`
googleapis · Dec 1, 2023 · 704674f · 704674f
1 parent e8966d1
commit 704674f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -19,7 +19,7 @@
   "dependencies": {
     "base64-js": "^1.3.0",
     "ecdsa-sig-formatter": "^1.0.11",
-    "gaxios": "^6.0.0",
+    "gaxios": "^6.1.1",
     "gcp-metadata": "^6.1.0",
     "gtoken": "^7.0.0",
     "jws": "^4.0.0"

diff --git a/src/auth/googleauth.ts b/src/auth/googleauth.ts
@@ -311,7 +311,7 @@ export class GoogleAuth<T extends AuthClient = JSONClient> {
       universeDomain = await gcpMetadata.universe('universe_domain');
       universeDomain ||= DEFAULT_UNIVERSE;
     } catch (e) {
-      if (e instanceof GaxiosError && e.status === 404) {
+      if (e && (e as GaxiosError)?.response?.status === 404) {
         universeDomain = DEFAULT_UNIVERSE;
       } else {
         throw e;