test: Log Error On Error (#1760)

* test: Log Error On Error * chore: type fix * refactor: revert accidental changes from another branch
googleapis · Feb 26, 2024 · 40c847f · 40c847f
1 parent 3b19e9c
commit 40c847f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/samples/test/externalclient.test.js b/samples/test/externalclient.test.js
@@ -290,7 +290,7 @@ describe('samples for external-account', () => {
       },
     });
     // Confirm expected script output.
-    assert.match(output, /DNS Info:/);
+    assert.match(output, /DNS Info:/, output);
   });
 
   it('should sign the blobs with IAM credentials API', async () => {
@@ -389,7 +389,7 @@ describe('samples for external-account', () => {
       },
     });
     // Confirm expected script output.
-    assert.match(output, /DNS Info:/);
+    assert.match(output, /DNS Info:/, output);
   });
 
   it('should acquire ADC for AWS creds', async () => {
@@ -427,7 +427,7 @@ describe('samples for external-account', () => {
       },
     });
     // Confirm expected script output.
-    assert.match(output, /DNS Info:/);
+    assert.match(output, /DNS Info:/, output);
   });
 
   it('should acquire ADC for PluggableAuth creds', async () => {
@@ -474,7 +474,7 @@ describe('samples for external-account', () => {
       },
     });
     // Confirm expected script output.
-    assert.match(output, /DNS Info:/);
+    assert.match(output, /DNS Info:/, output);
   });
 
   it('should acquire access token with service account impersonation options', async () => {

diff --git a/src/auth/oauth2client.ts b/src/auth/oauth2client.ts
@@ -854,7 +854,7 @@ export class OAuth2Client extends AuthClient {
 
   protected async getRequestMetadataAsync(
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    url?: string | null
+    url?: string | URL | null
   ): Promise<RequestMetadataResponse> {
     const thisCreds = this.credentials;
     if (