-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds CAB rules classes #687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 14, 2021
TimurSadykov
suggested changes
Jun 17, 2021
oauth2_http/java/com/google/auth/oauth2/CredentialAccessBoundary.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/CredentialAccessBoundaryTest.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/CredentialAccessBoundaryTest.java
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/CredentialAccessBoundary.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/CredentialAccessBoundary.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/CredentialAccessBoundaryTest.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/CredentialAccessBoundary.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Jun 17, 2021
oauth2_http/java/com/google/auth/oauth2/CredentialAccessBoundary.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/CredentialAccessBoundaryTest.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Jun 18, 2021
oauth2_http/java/com/google/auth/oauth2/CredentialAccessBoundary.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Jun 18, 2021
oauth2_http/java/com/google/auth/oauth2/CredentialAccessBoundary.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/CredentialAccessBoundary.java
Outdated
Show resolved
Hide resolved
elharo
approved these changes
Jun 19, 2021
TimurSadykov
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lsirac
added a commit
that referenced
this pull request
Aug 3, 2021
* feat: adds CAB rules classes (#687) * feat: adds CAB rules classes * fix: copyright * fix: revert pom * fix: review * fix: bad link * fix: more null and empty checks * fix: expand javadoc * fix: split null/empty checks * fix: use checkNotNull * feat: downscoping with credential access boundaries (#691) * feat: downscoping with credential access boundaries * fix: rename RefreshableOAuth2Credentials to OAuth2CredentialsWithRefresh * fix: review nits * test: adds integration tests for downscoping with credential access boundaries * fix: use source credential expiration when STS does not return expires_in * fix: require an expiration time to be passed in the AccessToken consumed by OAuth2CredentialsWithRefresh Co-authored-by: Elliotte Rusty Harold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CAB rule classes (see go/cab-client)