Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds CAB rules classes #687

Merged
merged 9 commits into from
Jun 21, 2021
Merged

feat: adds CAB rules classes #687

merged 9 commits into from
Jun 21, 2021

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Jun 14, 2021

Adds CAB rule classes (see go/cab-client)

@lsirac lsirac requested a review from a team as a code owner June 14, 2021 20:04
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@lsirac lsirac requested a review from TimurSadykov June 14, 2021 20:06
@lsirac lsirac requested review from elharo and TimurSadykov June 17, 2021 20:44
@lsirac lsirac requested a review from elharo June 18, 2021 19:02
@lsirac lsirac requested a review from elharo June 18, 2021 21:13
Copy link
Contributor

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsirac lsirac changed the base branch from master to cab June 21, 2021 18:49
@lsirac lsirac merged commit 68522fb into googleapis:cab Jun 21, 2021
lsirac added a commit that referenced this pull request Aug 3, 2021
* feat: adds CAB rules classes (#687)

* feat: adds CAB rules classes

* fix: copyright

* fix: revert pom

* fix: review

* fix: bad link

* fix: more null and empty checks

* fix: expand javadoc

* fix: split null/empty checks

* fix: use checkNotNull

* feat: downscoping with credential access boundaries (#691)

* feat: downscoping with credential access boundaries

* fix: rename RefreshableOAuth2Credentials to OAuth2CredentialsWithRefresh

* fix: review nits

* test: adds integration tests for downscoping with credential access boundaries

* fix: use source credential expiration when STS does not return expires_in

* fix: require an expiration time to be passed in the AccessToken consumed by OAuth2CredentialsWithRefresh

Co-authored-by: Elliotte Rusty Harold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants