Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Properly log errors as errors" #11561

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Revert "Properly log errors as errors" #11561

merged 1 commit into from
Sep 7, 2022

Conversation

bajajneha27
Copy link
Contributor

Reverts #6494

@bajajneha27 bajajneha27 marked this pull request as ready for review September 7, 2022 07:41
@bajajneha27 bajajneha27 requested a review from a team as a code owner September 7, 2022 07:41
dazuma
dazuma approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you merge as fix: so it triggers release-please.

@bajajneha27 bajajneha27 merged commit a722b87 into main Sep 7, 2022
@bajajneha27 bajajneha27 deleted the revert-6494-log-errors-as-errors branch September 7, 2022 13:19
@ylecuyer
Copy link
Contributor

ylecuyer commented Sep 7, 2022

@bajajneha27 would it be possible to know the reason leading to the revert?

@bajajneha27
Copy link
Contributor Author

Hi @ylecuyer
The change actually caused unnecessary logging for the tests. Check out #11312 and #18854
We'll come up with a better approach to handle this.

@yoshi-code-bot yoshi-code-bot mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazuma dazuma dazuma approved these changes

@shivgautam shivgautam shivgautam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bajajneha27 @ylecuyer @dazuma @shivgautam