Proactively refresh credentials when applying and treat a missing access_token as invalid. #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es_token as invalid. Closes #350, Supersedes #434 Note: This change reveals surprising behavior between default credentials and batches. If you allow `googleapiclient.discovery.build` to use default credentials *and* specify different credentials by providing `batch.execut()` with an explicit `http` argument, your individual requests will use the default credentials and *not* the credentials specified to the bathc http. To avoid this, tell `build` explicitly not to use default credentials by specifying `build(..., http=httplib2.Http()`. For context, see: #434 (comment)
googlebot
added
the
cla: yes
lukesneeringer
approved these changes
Jan 17, 2018
snarfed
added a commit
to snarfed/bridgy
that referenced
this pull request
Jan 18, 2018
we no longer need the bug fix in my fork now that we have the workaround in snarfed/oauth-dropins@7641605 and improved refresh token handling in googleapis/google-api-python-client#469.
snarfed
added a commit
to snarfed/bridgy
that referenced
this pull request
Oct 22, 2018
for #846. inspired by https://developers.googleblog.com/2018/03/discontinuing-support-for-json-rpc-and.html had to pay attention to googleapis/google-api-python-client#469 since it affects us, but we pass its criteria - we do `build(..., http=httplib2.Http())` explicitly - so we should be ok.
snarfed
added a commit
to snarfed/oauth-dropins
that referenced
this pull request
Oct 22, 2018
inspired by https://developers.googleblog.com/2018/03/discontinuing-support-for-json-rpc-and.html had to pay attention to googleapis/google-api-python-client#469 since it affects us, but we pass its criteria - we do `build(..., http=httplib2.Http())` explicitly - so we should be ok.
snarfed
added a commit
to snarfed/granary
that referenced
this pull request
Oct 22, 2018
inspired by https://developers.googleblog.com/2018/03/discontinuing-support-for-json-rpc-and.html had to pay attention to googleapis/google-api-python-client#469 since it affects us, but we pass its criteria - we do `build(..., http=httplib2.Http())` explicitly - so we should be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #350, Supersedes #434
Note: This change reveals surprising behavior between default credentials and batches. If you allow
googleapiclient.discovery.buildto use default credentials and specify different credentials by providingbatch.execute()with an explicithttpargument, your individual requests will use the default credentials and not the credentials specified to the batch http. To avoid this, tellbuildexplicitly not to use default credentials by specifyingbuild(..., http=httplib2.Http().For context, see:
#434 (comment)