Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when using mocking without cache. #261

Merged
merged 1 commit into from
Aug 16, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions googleapiclient/discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,15 @@ def build_from_document(

if isinstance(service, six.string_types):
service = json.loads(service)

if 'rootUrl' not in service and (isinstance(http, (HttpMock,
HttpMockSequence))):
logger.error("You are using HttpMock or HttpMockSequence without" +
"having the service discovery doc in cache. Try calling " +
"build() without mocking once first to populate the " +
"cache.")
raise InvalidJsonError()

base = urljoin(service['rootUrl'], service['servicePath'])
schema = Schemas(service)

Expand Down