Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry rate limits on chunk uploading #255

Merged
merged 1 commit into from
Jul 29, 2016
Merged

Retry rate limits on chunk uploading #255

merged 1 commit into from
Jul 29, 2016

Conversation

lichray
Copy link
Contributor

@lichray lichray commented Jul 28, 2016

No description provided.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 28, 2016
@lichray
Copy link
Contributor Author

lichray commented Jul 28, 2016

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 28, 2016
@nathanielmanistaatgoogle
Copy link
Contributor

This looks okay to me. @jonparrott, any thoughts?

How might this change get test coverage?

@theacodes
Copy link
Contributor

Change looks fine to me. @lichray can you update any relevant tests or let us know if they do not need to be updated (unlikely)?

@lichray lichray force-pushed the fix-next_chunk-backoff branch from 8370150 to 937c821 Compare July 28, 2016 18:42
@lichray lichray force-pushed the fix-next_chunk-backoff branch from 937c821 to cc6d398 Compare July 28, 2016 18:45
@lichray
Copy link
Contributor Author

lichray commented Jul 28, 2016

Tests added.

@theacodes
Copy link
Contributor

LGTM, merging. Thank you for your contribution. :)

@theacodes theacodes merged commit d976781 into googleapis:master Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@theacodes theacodes

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lichray @googlebot @nathanielmanistaatgoogle @theacodes