-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider minifying json shipped in package #1967
Comments
A related issue on the aws side: boto/botocore#2365. Their solution was to gzip the json files. |
At the moment the json files take 81.3MB on disk, which is a significant portion of my docker images. |
parthea
pushed a commit
that referenced
this issue
May 24, 2023
Changed the discovery artifact JSON indentation from 2 to 0, in order to reduce the size by several megabytes. Refs: #1967
parthea
added a commit
that referenced
this issue
Jan 8, 2024
Changed the discovery artifact JSON indentation from 2 to 0, in order to reduce the size by several megabytes. Refs: #1967 Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tl;dr we are deploying the SDK to aws lambdas and ran into a scenario where our primary layer became too large, initially we just stripped individual json files from discovery_cache/documents since this is by far the largest culprit (according to
ncdu
).I also noticed that all of these definitions are actually pretty printed json.
I'm suggesting 2 things:
Environment details
google-api-python-client
version: 2.64.0Steps to reproduce
ncdu
Code example
n/a
Stack trace
n/a
Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!
The text was updated successfully, but these errors were encountered: