uses guzzle StreamHandler by default [AppEngine only] #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
advantages: does not require |
bshaffer
force-pushed
the
switch-to-stream-handler-by-default
branch
from
1c07ef1 to
d32b7de
Compare
bshaffer
changed the title
bshaffer
force-pushed
the
switch-to-stream-handler-by-default
branch
from
d32b7de to
4d21613
Compare
bshaffer
added a commit
that referenced
this pull request
Nov 3, 2015
…ault uses guzzle StreamHandler by default [AppEngine only]
|
Seems like App Engine now supports cURL: Have you tried that? |
|
Sorry, apparently you tried them. I think we should make it (App Engine cURL support) work also. |
|
@tmatsuo yes, AppEngine supports cURL, but I was unable to get this library to work even so. I agree it would be better to fix the issue, but this is a good solution in the interim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for AppEngine calls to a succeed, otherwise the connection error
Curl Errno 7is thrown.We could only do this for when
isAppEngineis true, but I'm a fan of as few conditional checks as possible. Are there any downsides to defaulting to this StreamHandler over Curl?