Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the protected apiVersion property #2588

Merged
merged 3 commits into from
May 2, 2024
Merged

feat: Add the protected apiVersion property #2588

merged 3 commits into from
May 2, 2024

Conversation

Hectorhammett
Copy link
Contributor

Add the protected apiVersion property to the Resource class to support the new api version header.

@Hectorhammett Hectorhammett requested a review from a team as a code owner April 22, 2024 20:52
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@Hectorhammett Hectorhammett force-pushed the api-versioning branch 3 times, most recently from cf8ee77 to 4f094af Compare April 22, 2024 21:04
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a small feature, but I'd still like to see a test for it!

@Hectorhammett Hectorhammett force-pushed the api-versioning branch 2 times, most recently from d05024a to 9c499d9 Compare April 23, 2024 07:57
@Hectorhammett
Copy link
Contributor Author

@bshaffer Added!

@Hectorhammett Hectorhammett requested a review from bshaffer April 23, 2024 19:16
@bshaffer bshaffer enabled auto-merge (squash) May 2, 2024 16:33
@bshaffer bshaffer merged commit 7e79f3d into main May 2, 2024
12 checks passed
@bshaffer bshaffer deleted the api-versioning branch May 2, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants