Remove ClientLogin (#1224)

* Remove ClientLogin * Bump clirr comparison version and note that we are removing beta classes
googleapis · Jan 2, 2019 · dc9ed41 · dc9ed41
1 parent 2079c4c
commit dc9ed41
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 465 deletions.
diff --git a/clirr-ignored-differences.xml b/clirr-ignored-differences.xml
@@ -2,4 +2,8 @@
 <!-- see http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
 
 <differences>
+  <difference>
+    <differenceType>8001</differenceType>
+    <className>com/google/api/client/googleapis/auth/clientlogin/**</className>
+  </difference>
 </differences>
diff --git a/findbugs-exclude.xml b/findbugs-exclude.xml
@@ -6,23 +6,18 @@
   <LastVersion value="-1" relOp="NEQ"/>
   <!-- The following have not yet been investigated -->
 
-  <!-- The following are known to be bugs and should be fixed -->
-  <And>
-    <Package name="com.google.api.client.googleapis.auth.clientlogin"/>
-  </And>
-
   <!-- The following are known to NOT be bugs and should not be fixed -->
   <And>
-    <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/> 
-    <!-- Class doesn't override equals in superclass -->   
+    <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
+    <!-- Class doesn't override equals in superclass -->
     <Class name="com.google.api.client.googleapis.auth.oauth2.GoogleAuthorizationCodeRequestUrl"/>
   </And>
   <And>
-    <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>    
+    <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
     <Class name="com.google.api.client.googleapis.auth.oauth2.GoogleBrowserClientRequestUrl"/>
   </And>
   <And>
-    <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>    
+    <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
     <Class name="com.google.api.client.googleapis.GoogleUrl"/>
   </And>
   <And>
@@ -88,26 +83,26 @@
   <And>
     <Bug pattern="DM_STRING_CTOR"/>
     <!-- Method invokes inefficient new String(String) constructor -->
-    <Class name="com.google.api.client.googleapis.batch.BatchRequest"/>    
-  </And>  
+    <Class name="com.google.api.client.googleapis.batch.BatchRequest"/>
+  </And>
   <And>
     <Bug pattern="DM_STRING_CTOR"/>
     <!-- Method invokes inefficient new String(String) constructor -->
-    <Class name="com.google.api.client.googleapis.services.AbstractGoogleClient"/>    
-  </And>  
+    <Class name="com.google.api.client.googleapis.services.AbstractGoogleClient"/>
+  </And>
   <And>
     <Bug pattern="DM_STRING_CTOR"/>
     <!-- Method invokes inefficient new String(String) constructor -->
-    <Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential"/>    
-  </And>  
+    <Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential"/>
+  </And>
   <And>
     <Bug pattern="DM_STRING_CTOR"/>
     <!-- Method invokes inefficient new String(String) constructor -->
-    <Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential$RequestHandler"/>    
-  </And>  
+    <Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential$RequestHandler"/>
+  </And>
   <And>
     <Bug pattern="DM_STRING_CTOR"/>
     <!-- Method invokes inefficient new String(String) constructor -->
-    <Class name="com.google.api.client.googleapis.xml.atom.MultiKindFeedParser"/>    
-  </And>  
+    <Class name="com.google.api.client.googleapis.xml.atom.MultiKindFeedParser"/>
+  </And>
 </FindBugsFilter>
diff --git a/...t/src/main/java/com/google/api/client/googleapis/auth/clientlogin/AuthKeyValueParser.java b/...t/src/main/java/com/google/api/client/googleapis/auth/clientlogin/AuthKeyValueParser.java