Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(option): add support for env var GOOGLE_CLOUD_UNIVERSE_DOMAIN #2509

Merged
merged 3 commits into from
Apr 8, 2024
Merged

feat(option): add support for env var GOOGLE_CLOUD_UNIVERSE_DOMAIN #2509

merged 3 commits into from
Apr 8, 2024

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Apr 5, 2024

  • Remove unneeded DefaultUniverseDomain usages.

@quartzmo quartzmo requested a review from a team as a code owner April 5, 2024 20:20
@quartzmo quartzmo force-pushed the option-universe-domain-env-var branch from f79180b to 1ba3330 Compare April 5, 2024 20:45
codyoss
codyoss reviewed Apr 5, 2024
View reviewed changes
internal/settings.go Outdated Show resolved Hide resolved
@quartzmo quartzmo merged commit 4e450ec into googleapis:main Apr 8, 2024
5 checks passed
@quartzmo quartzmo deleted the option-universe-domain-env-var branch April 8, 2024 16:36
@release-please release-please bot mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quartzmo @codyoss