docs: add sample for all data types #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
hengfengli
reviewed
Oct 20, 2021
examples/data-types/main.go
Outdated
| float64 sql.NullFloat64 | ||
| numeric spanner.NullNumeric // There is no sql.NullNumeric type | ||
| date spanner.NullDate // There is no sql.NullDate type | ||
| timestamp spanner.NullTime |
There was a problem hiding this comment.
there is no sql.NullTime?
There was a problem hiding this comment.
Yes, there is. Good catch, thanks.
hengfengli
reviewed
Oct 20, 2021
examples/go.mod
Outdated
| @@ -5,13 +5,14 @@ go 1.14 | |||
| replace github.com/cloudspannerecosystem/go-sql-spanner => ../ | |||
|
|
|||
| require ( | |||
| cloud.google.com/go/spanner v1.25.0 | |||
| cloud.google.com/go v0.97.0 | |||
| cloud.google.com/go/spanner v1.26.1-0.20211019074412-4537b45d2611 | |||
There was a problem hiding this comment.
do you want to upgrade to 1.27?
There was a problem hiding this comment.
Yes, thanks for releasing that so quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sample for how to use all supported data types.
This sample depends on very recent changes in the Spanner client library that have not yet been officially released: googleapis/google-cloud-go#4936