fix: reconnect after all idle connections close #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all connnections attached to the connector closed then the spanner client and admin client was closed. This is a problem, because the database may still hold on to the connector and may want to make new connections. This changes the logic such that the connector can reconnect the client when necessary. Fixes googleapis#288
Implement the Closer interface for connector and use that to remove it from the list of active connectors. Closing all idle connections of a connector will close the underlying clients, but allow these to be re-initialized if the connector is used again. Re-using a connector that has been closed is not possible.
|
@egonelbre I made a small change to this PR, as removing/adding the connector from the map of driver connectors when all connections were closed caused some flaky test failures, probably due to underlying connections being closed right at the same time as that a new connection was being requested for the same connector. |
olavloite
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all connnections attached to the connector closed then the spanner
client and admin client was closed. This is a problem, because the
database may still hold on to the connector and may want to make new
connections.
This changes the logic such that the connector can reconnect the client
when necessary.