fix: support uint query params #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver did accept query parameters of type `uint`, but the underlying Spanner client would not accept these. `uint` query parameters therefore first need to be converted to `int64` and then sent to the Spanner client.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
🤖 I have created a release *beep* *boop* --- ## [1.2.1](https://togithub.com/googleapis/go-sql-spanner/compare/v1.2.0...v1.2.1) (2024-02-05) ### Bug Fixes * Support uint query params ([#190](https://togithub.com/googleapis/go-sql-spanner/issues/190)) ([e3e2a9a](https://togithub.com/googleapis/go-sql-spanner/commit/e3e2a9a9fd14f2a4940dd24e73a5a79aa0431580)) ### Documentation * Add link to pgx sample for PGAdapter ([#191](https://togithub.com/googleapis/go-sql-spanner/issues/191)) ([e9f8e90](https://togithub.com/googleapis/go-sql-spanner/commit/e9f8e901b5cc345344d9369b92df8d093b4d47a8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver did accept query parameters of type
uint, but the underlying Spanner client would not accept these.uintquery parameters therefore first need to be converted toint64and then sent to the Spanner client.