feat: significantly increase timeout if GCF environment detected #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By eliminating caching, and creating a large number of concurrent requests, I was able to create similar behavior to that described in #798. The root cause seems to be reduced network performance when a function is initially deployed. This PR detects a GCF runtime, based on environment variables, and significantly extends network timeouts.
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Feb 19, 2020
zamnuts
reviewed
Feb 19, 2020
feywind
approved these changes
Feb 19, 2020
bcoe
changed the title
bcoe
force-pushed
the
detect-runtime-extend-timeout
branch
from
c110c70 to
244a670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By eliminating caching, and creating a large number of concurrent requests, I was able
to create similar behavior to that described in #798. The root cause seems to be reduced
network performance when a function is initially deployed.
This PR detects a GCF runtime, based on environment variables, and significantly extends
network timeouts.
Based on testing, this should help mitigate the behavior in googleapis/google-auth-library-nodejs#798 (although the behavior of throttled network requests might still be unpredictable) and we probably close 798 until googleapis/gapic-generator-typescript#287 lands.