Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Do not treat Buffers as JSON by default #621

Merged
merged 35 commits into from
Oct 30, 2024
Merged

feat!: Do not treat Buffers as JSON by default #621

merged 35 commits into from
Oct 30, 2024

Conversation

danielbankhead
Copy link
Contributor

@danielbankhead danielbankhead commented May 15, 2024 •
edited
Loading

@generated-files-bot Generated Files Bot
Copy link

generated-files-bot bot commented May 15, 2024 •
edited
Loading

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 15, 2024
@danielbankhead danielbankhead mentioned this pull request May 15, 2024
Closed
d-goog added 14 commits May 15, 2024 13:05
@d-goog
Merge branch 'main' of github.com:googleapis/gaxios into upgrade-node…
93bf4a8 
…-fetch
@d-goog
Merge branch 'upgrade-node-fetch' of github.com:googleapis/gaxios int…
273e516 
…o do-not-treat-buffer-as-json
@d-goog
test: Adopt Headers type from merge
9164b87
@d-goog
Merge branch 'upgrade-node-fetch' of github.com:googleapis/gaxios int…
d01ecde 
…o do-not-treat-buffer-as-json
@d-goog
feat: Introduce GaxiosOptionsPrepared for improved type guarantees
84faea8
@d-goog
feat: Ensure GaxiosOptionsPrepared.url is always a URL
4e6de5f
@d-goog
refactor: Clean-up Types & Resolve lint warnings
e6c2371
@d-goog
Merge branch 'upgrade-node-fetch' of github.com:googleapis/gaxios int…
2089d83 
…o do-not-treat-buffer-as-json
@d-goog
refactor: streamline .data for Response
98f7009
@d-goog
Merge branch 'upgrade-node-fetch' of github.com:googleapis/gaxios int…
e66c4ba 
…o do-not-treat-buffer-as-json
@d-goog
docs: Simplify example
4894e39
@d-goog
refactor: streamline, no error case
a7e2e83
@d-goog
Merge branch 'main' of github.com:googleapis/gaxios into do-not-treat…
0baab44 
…-buffer-as-json
@d-goog
docs: clarification
b2ec395
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 1, 2024
@danielbankhead danielbankhead added the next major: breaking change this is a change that we should wait to bundle into the next major version label Jul 1, 2024
@danielbankhead danielbankhead changed the base branch from upgrade-node-fetch to main July 2, 2024 21:50
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Sep 11, 2024
@danielbankhead danielbankhead marked this pull request as ready for review October 25, 2024 18:13
@danielbankhead danielbankhead requested a review from a team as a code owner October 25, 2024 18:13
@sofisl
Copy link
Contributor

sofisl commented Oct 29, 2024

Is there a FR tied to this?

@sofisl sofisl mentioned this pull request Oct 29, 2024
Merged
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Oct 29, 2024
@danielbankhead
Copy link
Contributor Author

@sofisl more-so bug reports and difficult to catch behavior:

sofisl
sofisl requested changes Oct 30, 2024
View reviewed changes
test/test.getch.ts
@@ -1112,22 +1112,6 @@ describe('🍂 defaults & instances', () => {
assert.deepStrictEqual(res.data, {});
});

it('should set content-type to application/json by default, for buffer', async () => {
Copy link
Contributor

@sofisl sofisl Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we write a test that asserts the behavior for what happens if a buffer does get sent in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it’s mostly a partial revert of:

but that can be added.

@danielbankhead danielbankhead merged commit f3c1e76 into main Oct 30, 2024
14 checks passed
@danielbankhead danielbankhead deleted the do-not-treat-buffer-as-json branch October 30, 2024 22:33
@release-please release-please bot mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbankhead @sofisl @d-goog