This repository has been archived by the owner on Mar 20, 2018. It is now read-only.
Update to support bundling #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides access to bundling through ApiCallable. Replaces ApiCallDefaults with CallSettings, which corresponds to a change in the code generation to pass bundling settings through to ApiCallable.
| the_func = _add_timeout_arg(the_func, timeout) | ||
| the_func = _add_timeout_arg(the_func, self.settings.timeout) | ||
| if self.settings.bundler and self.settings.bundle_descriptor: | ||
| the_func = _bundleable( |
There was a problem hiding this comment.
N.B: At this point, _bundleable is called with the_func which is still a callable([[request], response])
I refer to this in another comment.
There was a problem hiding this comment.
We start out with (if you'll forgive some haskell-ish notation):
the_func :: (RequestType, int) -> (ResponseType)
_add_timeout_arg :: ((type_1, ..., type_n, int) -> X), int) -> (type_1, ..., type_n) -> X
hence,
_add_timeout_arg(the_func) :: RequestType -> ResponseType
So I think in test_api_callable, my_func must take a dummy_timeout, or else we can't meaningfully apply _add_timeout_arg to it in ApiCallable. Does that sounds right?
|
LGTM |
bjwatson
pushed a commit
to googleapis/gapic-generator
that referenced
this pull request
Apr 20, 2016
Introduces bundling into Python VGen. To accomodate bundling, the defaults/options system has been reworked; ApiCallDefaults is removed. Instead, a dictionary is maintained which associates defaults to each method; the values in the dictionary are then merged with any CallOptions passed in while a call is being made. A corresponding change to GAX is here: googleapis/gax-python#28 Note that it is not currently possible to override the bundling defaults when calling the API constructor; a later change will add the ability to pass in a dictionary mapping method names to bundlers in order to provide this functionality. Change-Id: I434a6026882fa57ec0d4672bff8be4f4102c4a82
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides access to bundling through ApiCallable. Replaces
ApiCallDefaults with CallSettings, which corresponds to a change
in the code generation to pass bundling settings through to
ApiCallable.