Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set element_count_limit param as optional for bundling config #747

Closed
wants to merge 1 commit into from

Conversation

xiaozhenliu-gg5
Copy link
Contributor

Fix type compile error: googleapis/gapic-generator-typescript#330

This field is required in BundlingConfig from gax, but not set in service_client_config.json from API.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2020
@xiaozhenliu-gg5
Copy link
Contributor Author

We have another workaround to set this number as default large if we don't specify it.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #747 into master will decrease coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
- Coverage   89.54%   89.14%   -0.41%     
==========================================
  Files          45       43       -2     
  Lines        7344     7211     -133     
  Branches      468      452      -16     
==========================================
- Hits         6576     6428     -148     
- Misses        765      780      +15     
  Partials        3        3
Impacted Files Coverage Δ
src/gax.ts 96.1% <100%> (ø) ⬆️
src/fallback.ts 73.68% <0%> (-2.88%) ⬇️
src/streamingCalls/streamingApiCaller.ts 89.24% <0%> (-1.08%) ⬇️
src/grpc.ts 89.23% <0%> (-0.57%) ⬇️
samples/pagination.js
samples/quickstart.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1eccf9...3291092. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants