-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds unit tests for sync and async reads of a pipeline transformation #1663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of overall pieces of feedback:
- I think a test should also be added to the test application that does this
- I know our problem before was the test timing out because "done" was never called, but also make sure it's possible for it to fail and to fail LOUDLY :)! It might in its current state, but it might not , which is why I added those notes about "done" and the errors
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just these nits
Co-authored-by: Leah E. Cole <[email protected]>
Co-authored-by: Leah E. Cole <[email protected]>
Warning: This pull request is touching the following templated files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the compodoc stuff as a separate pr!
|
Discovered there may be some unit test coverage needed to test pipeline transformations during a Cloud Bigtable feature PR (googleapis/nodejs-bigtable#1494).