Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds unit tests for sync and async reads of a pipeline transformation #1663

Merged
merged 25 commits into from
Oct 25, 2024

Conversation

kevkim-codes
Copy link
Contributor

Discovered there may be some unit test coverage needed to test pipeline transformations during a Cloud Bigtable feature PR (googleapis/nodejs-bigtable#1494).

@kevkim-codes kevkim-codes requested review from a team as code owners October 2, 2024 17:30
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 2, 2024
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of overall pieces of feedback:

  • I think a test should also be added to the test application that does this
  • I know our problem before was the test timing out because "done" was never called, but also make sure it's possible for it to fail and to fail LOUDLY :)! It might in its current state, but it might not , which is why I added those notes about "done" and the errors

gax/test/unit/streaming.ts Show resolved Hide resolved
gax/test/unit/streaming.ts Outdated Show resolved Hide resolved
gax/test/unit/streaming.ts Outdated Show resolved Hide resolved
gax/test/unit/streaming.ts Outdated Show resolved Hide resolved
gax/test/unit/streaming.ts Outdated Show resolved Hide resolved
@kevkim-codes
Copy link
Contributor Author

A couple of overall pieces of feedback:

  • I think a test should also be added to the test application that does this
  • I know our problem before was the test timing out because "done" was never called, but also make sure it's possible for it to fail and to fail LOUDLY :)! It might in its current state, but it might not , which is why I added those notes about "done" and the errors
  1. Sounds good. I will have a separate PR for the test application.

  2. Incorporated your changes in the review and made the error handling better, thank you!

@leahecole leahecole self-assigned this Oct 10, 2024
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just these nits

gax/test/unit/streaming.ts Outdated Show resolved Hide resolved
gax/test/unit/streaming.ts Outdated Show resolved Hide resolved
@kevkim-codes kevkim-codes changed the title feat: adds a unit test that tests starts and resolves a pipeline transformation feat: adds unit tests for sync and sync reads of a pipeline transformation Oct 10, 2024
@kevkim-codes kevkim-codes changed the title feat: adds unit tests for sync and sync reads of a pipeline transformation feat: adds unit tests for sync and async reads of a pipeline transformation Oct 10, 2024
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the compodoc stuff as a separate pr!

@leahecole leahecole added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 21, 2024
gax/package.json Outdated Show resolved Hide resolved
gax/package.json Outdated Show resolved Hide resolved
@kevkim-codes kevkim-codes requested a review from a team as a code owner October 24, 2024 18:50
@kevkim-codes
Copy link
Contributor Author

Please add the compodoc stuff as a separate pr!
Removed!

@kevkim-codes kevkim-codes added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2024
@kevkim-codes kevkim-codes added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2024
@kevkim-codes kevkim-codes merged commit c7995c4 into googleapis:main Oct 25, 2024
18 checks passed
@release-please release-please bot mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants