Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test failures because of transitive dependency #1657

Closed
leahecole opened this issue Sep 23, 2024 · 0 comments · Fixed by #1658
Closed

test failures because of transitive dependency #1657

leahecole opened this issue Sep 23, 2024 · 0 comments · Fixed by #1658
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@leahecole
Copy link
Contributor

When trying to run tests on PRs, we see a failure because the dependency pdfmake, which is an underlying dependency of @compodoc/compodoc released a new version that is only Node 18 or higher. Later versions of compodoc do not use pdfmake, but have other transitive dependencies that cause similar failures
@leahecole leahecole added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 23, 2024
@leahecole leahecole mentioned this issue Sep 23, 2024
Merged
leahecole added a commit that referenced this issue Sep 23, 2024
@leahecole
fixes #1657
bc1bdd0
leahecole added a commit that referenced this issue Sep 23, 2024
@leahecole
fix: add overrides to fix #1657
1ef68bb
@leahecole leahecole mentioned this issue Sep 23, 2024
Merged
leahecole added a commit that referenced this issue Sep 24, 2024
@leahecole
fix: add dependency to fix tests (#1658)
564e9e7 
* fix: add overrides to fix #1657

* fix: remove overrides, install pdfmake directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add dependency to fix tests googleapis/gax-nodejs
1 participant
@leahecole