-
Notifications
You must be signed in to change notification settings - Fork 107
fix: Watchdog.shutdownNow() does not shutdown executor #1158
fix: Watchdog.shutdownNow() does not shutdown executor #1158
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
============================================
- Coverage 79.07% 79.07% -0.01%
Complexity 1193 1193
============================================
Files 205 205
Lines 5258 5257 -1
Branches 433 433
============================================
- Hits 4158 4157 -1
Misses 929 929
Partials 171 171
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Thanks!
Fixes #870 , see my comment