Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace use of github.com/golang/protobuf/proto with google.golang.org/protobuf/proto #1525

Closed
julieqiu opened this issue Aug 14, 2024 · 1 comment · Fixed by #1534 or #1558
Closed

replace use of github.com/golang/protobuf/proto with google.golang.org/protobuf/proto #1525

julieqiu opened this issue Aug 14, 2024 · 1 comment · Fixed by #1534 or #1558
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@julieqiu
Copy link
Member

github.com/golang/protobuf/proto is deprecated, and we should use google.golang.org/protobuf package instead
@julieqiu julieqiu added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 14, 2024
@julieqiu julieqiu changed the title upgrade from github.com/golang/protobuf/proto to google.golang.org/protobuf replace use of github.com/golang/protobuf/proto with google.golang.org/protobuf Aug 14, 2024
@julieqiu julieqiu mentioned this issue Aug 14, 2024
Open
@julieqiu julieqiu changed the title replace use of github.com/golang/protobuf/proto with google.golang.org/protobuf replace use of github.com/golang/protobuf/proto with google.golang.org/protobuf/proto Aug 19, 2024
@julieqiu julieqiu mentioned this issue Aug 19, 2024
Merged
@codyoss codyoss reopened this Dec 3, 2024
@codyoss
Copy link
Member

codyoss commented Dec 3, 2024

Going to revert the corresponding linked PR. This broke the build and I think touched generated files manually. I am not sure why CI passed.

@codyoss codyoss mentioned this issue Dec 4, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 4, 2024
@codyoss
fix: replace use of github.com/golang/protobuf/proto where possible (#…
0215dd6 
…1557)

This is basically b9f8777 but removing changes that were from generated files.

Updates: #1525
@release-please release-please bot mentioned this issue Dec 4, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 4, 2024
@release-please
chore(main): release 0.35.5 (#1558)
91145cb 
🤖 I have created a release *beep* *boop*
---


## [0.35.5](https://togithub.com/googleapis/gapic-showcase/compare/v0.35.4...v0.35.5) (2024-12-04)


### Bug Fixes

* Replace use of github.com/golang/protobuf/proto where possible ([#1557](https://togithub.com/googleapis/gapic-showcase/issues/1557)) ([0215dd6](https://togithub.com/googleapis/gapic-showcase/commit/0215dd637e130ca0c0a74adcc74d34d3373060d8)), closes [#1525](https://togithub.com/googleapis/gapic-showcase/issues/1525)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@julieqiu @codyoss