Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

chore: fix showcase timeout-backoff test #3283

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Sep 28, 2020

Fixing a showcase Java test I added recently that verified some emergent behavior of logic that has since been fixed with googleapis/gax-java#1191. This code change should make the test resilient to the correction.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2020
@noahdietz noahdietz force-pushed the fix-timeout-backoff-test branch from 7d94ad8 to de8049f Compare September 28, 2020 21:45
@noahdietz noahdietz force-pushed the fix-timeout-backoff-test branch from de8049f to a1136bb Compare September 28, 2020 22:03
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #3283 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3283   +/-   ##
=========================================
  Coverage     87.12%   87.12%           
  Complexity     6081     6081           
=========================================
  Files           494      494           
  Lines         24066    24066           
  Branches       2615     2615           
=========================================
  Hits          20967    20967           
  Misses         2236     2236           
  Partials        863      863           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3a097...a1136bb. Read the comment docs.

@noahdietz noahdietz marked this pull request as ready for review September 28, 2020 22:20
@noahdietz noahdietz requested a review from a team as a code owner September 28, 2020 22:20
@noahdietz noahdietz requested a review from miraleung September 28, 2020 22:20
@noahdietz noahdietz merged commit 5b8e965 into googleapis:master Sep 28, 2020
@noahdietz noahdietz deleted the fix-timeout-backoff-test branch September 28, 2020 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants