Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Timeout millis is used by some languages #2707

Merged
merged 3 commits into from
Apr 11, 2019

Conversation

andreamlin
Copy link
Contributor

Still used by Ruby, Nodejs, Python.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 11, 2019
@andreamlin andreamlin force-pushed the timeout_millis_back branch from 395a3d8 to f9dfc3d Compare April 11, 2019 01:49
@andreamlin andreamlin force-pushed the timeout_millis_back branch from f9dfc3d to ea0c6c6 Compare April 11, 2019 01:50
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #2707 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2707      +/-   ##
============================================
+ Coverage     86.83%   86.88%   +0.04%     
+ Complexity     5609     5607       -2     
============================================
  Files           468      466       -2     
  Lines         22423    22387      -36     
  Branches       2440     2433       -7     
============================================
- Hits          19471    19450      -21     
+ Misses         2091     2084       -7     
+ Partials        861      853       -8
Impacted Files Coverage Δ Complexity Δ
.../transformer/java/JavaSampleImportTransformer.java 93.68% <0%> (-3.97%) 29% <0%> (ø)
...api/codegen/transformer/ruby/RubySurfaceNamer.java 93.33% <0%> (-1.03%) 89% <0%> (-1%)
.../transformer/ruby/RubyGapicSurfaceTransformer.java 99.29% <0%> (-0.36%) 46% <0%> (-1%)
...gle/api/codegen/transformer/OutputTransformer.java 89.97% <0%> (-0.34%) 53% <0%> (-3%)
...codegen/transformer/nodejs/NodeJSSurfaceNamer.java 88.18% <0%> (-0.15%) 94% <0%> (ø)
...n/transformer/StandardSampleImportTransformer.java 100% <0%> (ø) 6% <0%> (-1%) ⬇️
...google/api/codegen/viewmodel/MethodSampleView.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
.../transformer/py/PythonGapicSamplesTransformer.java 100% <0%> (ø) 19% <0%> (ø) ⬇️
...a/com/google/api/codegen/viewmodel/OutputView.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
...nsformer/nodejs/NodeJSGapicSamplesTransformer.java 100% <0%> (ø) 10% <0%> (ø) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977d6c2...ca804fa. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #2707 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2707      +/-   ##
============================================
- Coverage     86.83%   86.79%   -0.04%     
+ Complexity     5609     5593      -16     
============================================
  Files           468      466       -2     
  Lines         22423    22387      -36     
  Branches       2440     2433       -7     
============================================
- Hits          19471    19431      -40     
- Misses         2091     2093       +2     
- Partials        861      863       +2
Impacted Files Coverage Δ Complexity Δ
.../transformer/java/JavaSampleImportTransformer.java 93.68% <0%> (-3.97%) 29% <0%> (ø)
...gle/api/codegen/transformer/OutputTransformer.java 89.97% <0%> (-0.34%) 53% <0%> (-3%)
...codegen/transformer/nodejs/NodeJSSurfaceNamer.java 88.18% <0%> (-0.15%) 94% <0%> (ø)
...n/transformer/StandardSampleImportTransformer.java 100% <0%> (ø) 6% <0%> (-1%) ⬇️
...api/codegen/transformer/ruby/RubySurfaceNamer.java 94.35% <0%> (ø) 90% <0%> (ø) ⬇️
...google/api/codegen/viewmodel/MethodSampleView.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
.../transformer/py/PythonGapicSamplesTransformer.java 100% <0%> (ø) 19% <0%> (ø) ⬇️
...a/com/google/api/codegen/viewmodel/OutputView.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
...nsformer/nodejs/NodeJSGapicSamplesTransformer.java 100% <0%> (ø) 10% <0%> (ø) ⬇️
...a/com/google/api/codegen/config/OutputContext.java
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977d6c2...317bf4c. Read the comment docs.

@andreamlin
Copy link
Contributor Author

PTAL

@andreamlin andreamlin merged commit 9f5db47 into googleapis:master Apr 11, 2019
@andreamlin andreamlin deleted the timeout_millis_back branch April 11, 2019 16:45
busunkim96 pushed a commit to busunkim96/gapic-generator that referenced this pull request Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants