This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
Timeout millis is used by some languages #2707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 11, 2019
andreamlin
force-pushed
the
timeout_millis_back
branch
from
April 11, 2019 01:49
395a3d8
to
f9dfc3d
Compare
andreamlin
force-pushed
the
timeout_millis_back
branch
from
April 11, 2019 01:50
f9dfc3d
to
ea0c6c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2707 +/- ##
============================================
+ Coverage 86.83% 86.88% +0.04%
+ Complexity 5609 5607 -2
============================================
Files 468 466 -2
Lines 22423 22387 -36
Branches 2440 2433 -7
============================================
- Hits 19471 19450 -21
+ Misses 2091 2084 -7
+ Partials 861 853 -8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2707 +/- ##
============================================
- Coverage 86.83% 86.79% -0.04%
+ Complexity 5609 5593 -16
============================================
Files 468 466 -2
Lines 22423 22387 -36
Branches 2440 2433 -7
============================================
- Hits 19471 19431 -40
- Misses 2091 2093 +2
- Partials 861 863 +2
Continue to review full report at Codecov.
|
PTAL |
michaelbausor
approved these changes
Apr 11, 2019
busunkim96
pushed a commit
to busunkim96/gapic-generator
that referenced
this pull request
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still used by Ruby, Nodejs, Python.