fix: add null request for bi_di stream call (#1066)

* fix: add null request for bi_di stream call * update the unit test for bidi stream
googleapis · Dec 6, 2021 · 1149cb1 · 1149cb1
1 parent b56c01f
commit 1149cb1
Show file tree

Hide file tree

Showing 12 changed files with 18 additions and 18 deletions.
diff --git a/baselines/disable-packing-test/src/v1beta1/echo_client.ts.baseline b/baselines/disable-packing-test/src/v1beta1/echo_client.ts.baseline
@@ -593,7 +593,7 @@ export class EchoClient {
       options?: CallOptions):
     gax.CancellableStream {
     this.initialize();
-    return this.innerApiCalls.chat(options);
+    return this.innerApiCalls.chat(null, options);
   }
 
 /**

diff --git a/baselines/disable-packing-test/src/v1beta1/messaging_client.ts.baseline b/baselines/disable-packing-test/src/v1beta1/messaging_client.ts.baseline
@@ -1034,7 +1034,7 @@ export class MessagingClient {
       options?: CallOptions):
     gax.CancellableStream {
     this.initialize();
-    return this.innerApiCalls.connect(options);
+    return this.innerApiCalls.connect(null, options);
   }
 
 /**

diff --git a/baselines/disable-packing-test/test/gapic_echo_v1beta1.ts.baseline b/baselines/disable-packing-test/test/gapic_echo_v1beta1.ts.baseline
@@ -521,7 +521,7 @@ describe('v1beta1.EchoClient', () => {
             const response = await promise;
             assert.deepStrictEqual(response, expectedResponse);
             assert((client.innerApiCalls.chat as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });
@@ -547,7 +547,7 @@ describe('v1beta1.EchoClient', () => {
             });
             await assert.rejects(promise, expectedError);
             assert((client.innerApiCalls.chat as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });

diff --git a/baselines/disable-packing-test/test/gapic_messaging_v1beta1.ts.baseline b/baselines/disable-packing-test/test/gapic_messaging_v1beta1.ts.baseline
@@ -1103,7 +1103,7 @@ describe('v1beta1.MessagingClient', () => {
             const response = await promise;
             assert.deepStrictEqual(response, expectedResponse);
             assert((client.innerApiCalls.connect as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });
@@ -1129,7 +1129,7 @@ describe('v1beta1.MessagingClient', () => {
             });
             await assert.rejects(promise, expectedError);
             assert((client.innerApiCalls.connect as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });

diff --git a/baselines/showcase-legacy/src/v1beta1/echo_client.ts.baseline b/baselines/showcase-legacy/src/v1beta1/echo_client.ts.baseline
@@ -552,7 +552,7 @@ export class EchoClient {
       options?: CallOptions):
     gax.CancellableStream {
     this.initialize();
-    return this.innerApiCalls.chat(options);
+    return this.innerApiCalls.chat(null, options);
   }
 
 /**

diff --git a/baselines/showcase-legacy/test/gapic_echo_v1beta1.ts.baseline b/baselines/showcase-legacy/test/gapic_echo_v1beta1.ts.baseline
@@ -514,7 +514,7 @@ describe('v1beta1.EchoClient', () => {
             const response = await promise;
             assert.deepStrictEqual(response, expectedResponse);
             assert((client.innerApiCalls.chat as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });
@@ -540,7 +540,7 @@ describe('v1beta1.EchoClient', () => {
             });
             await assert.rejects(promise, expectedError);
             assert((client.innerApiCalls.chat as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });

diff --git a/baselines/showcase/src/v1beta1/echo_client.ts.baseline b/baselines/showcase/src/v1beta1/echo_client.ts.baseline
@@ -599,7 +599,7 @@ export class EchoClient {
       options?: CallOptions):
     gax.CancellableStream {
     this.initialize();
-    return this.innerApiCalls.chat(options);
+    return this.innerApiCalls.chat(null, options);
   }
 
 /**

diff --git a/baselines/showcase/src/v1beta1/messaging_client.ts.baseline b/baselines/showcase/src/v1beta1/messaging_client.ts.baseline
@@ -1040,7 +1040,7 @@ export class MessagingClient {
       options?: CallOptions):
     gax.CancellableStream {
     this.initialize();
-    return this.innerApiCalls.connect(options);
+    return this.innerApiCalls.connect(null, options);
   }
 
 /**

diff --git a/baselines/showcase/test/gapic_echo_v1beta1.ts.baseline b/baselines/showcase/test/gapic_echo_v1beta1.ts.baseline
@@ -521,7 +521,7 @@ describe('v1beta1.EchoClient', () => {
             const response = await promise;
             assert.deepStrictEqual(response, expectedResponse);
             assert((client.innerApiCalls.chat as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });
@@ -547,7 +547,7 @@ describe('v1beta1.EchoClient', () => {
             });
             await assert.rejects(promise, expectedError);
             assert((client.innerApiCalls.chat as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });

diff --git a/baselines/showcase/test/gapic_messaging_v1beta1.ts.baseline b/baselines/showcase/test/gapic_messaging_v1beta1.ts.baseline
@@ -1103,7 +1103,7 @@ describe('v1beta1.MessagingClient', () => {
             const response = await promise;
             assert.deepStrictEqual(response, expectedResponse);
             assert((client.innerApiCalls.connect as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });
@@ -1129,7 +1129,7 @@ describe('v1beta1.MessagingClient', () => {
             });
             await assert.rejects(promise, expectedError);
             assert((client.innerApiCalls.connect as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });

diff --git a/templates/typescript_gapic/src/$version/$service_client.ts.njk b/templates/typescript_gapic/src/$version/$service_client.ts.njk
@@ -593,7 +593,7 @@ export class {{ service.name }}Client {
     {%- if method.options and method.options.deprecated %}
     this.warn('DEP${{service.name}}-${{method.name}}','{{method.name}} is deprecated and may be removed in a future version.', 'DeprecationWarning');
     {%- endif %}
-    return this.innerApiCalls.{{ method.name.toCamelCase() }}(options);
+    return this.innerApiCalls.{{ method.name.toCamelCase() }}(null, options);
   }
 {%- elif method.serverStreaming %}
 /**

diff --git a/templates/typescript_gapic/test/gapic_$service_$version.ts.njk b/templates/typescript_gapic/test/gapic_$service_$version.ts.njk
@@ -548,7 +548,7 @@ describe('{{ api.naming.version }}.{{ service.name }}Client', () => {
             {%- endif %}
             assert.deepStrictEqual(response, expectedResponse);
             assert((client.innerApiCalls.{{ method.name.toCamelCase() }} as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });
@@ -578,7 +578,7 @@ describe('{{ api.naming.version }}.{{ service.name }}Client', () => {
             assert(stub.calledOnce);
             {%- endif %}
             assert((client.innerApiCalls.{{ method.name.toCamelCase() }} as SinonStub)
-                .getCall(0).calledWithExactly(undefined));
+                .getCall(0).calledWith(null));
             assert.deepStrictEqual(((stream as unknown as PassThrough)
                 ._transform as SinonStub).getCall(0).args[0], request);
         });