Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Remove monolith imports from Python µgen Bazel rules #923

Merged
merged 6 commits into from
Jun 21, 2021
Merged

fix(bazel): Remove monolith imports from Python µgen Bazel rules #923

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd97719
fix(bazel): Remove monolith imports from Python µgen Bazel rules
miraleung Jun 18, 2021
86002ce
fix: temporarily disable integration tests
miraleung Jun 18, 2021
2e85f28
Merge branch 'master' into fix/bazel
miraleung Jun 18, 2021
a24dbba
chore: empty commit to rerun CI
miraleung Jun 18, 2021
8feb9c4
Merge branch 'fix/bazel' of github.com:googleapis/gapic-generator-pyt…
miraleung Jun 18, 2021
e4f8b81
Merge branch 'master' into fix/bazel
software-dov Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,10 @@ jobs:
env:
BAZEL_VERSION: 3.5.0
BAZEL_BINARY: bazel_3.5.0-linux-x86_64.deb
- name: Integration Tests
run: bazel test tests/integration:asset tests/integration:credentials tests/integration:logging tests/integration:redis
# Temporarily disable integration tests due to a circular Bazel rule dependency.
# TODO(miraleung): Uncomment these once the monolith is gone from googleapis.
#- name: Integration Tests
#run: bazel test tests/integration:asset tests/integration:credentials tests/integration:logging tests/integration:redis

style-check:
runs-on: ubuntu-latest
Expand Down
9 changes: 1 addition & 8 deletions repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,7 @@ def gapic_generator_python():
url = "https://github.com/jgm/pandoc/releases/download/2.2.1/pandoc-2.2.1-macOS.zip",
)

_maybe(
http_archive,
name = "com_google_api_codegen",
strip_prefix = "gapic-generator-03abac35ec0716c6f426ffc1532f9a62f1c9e6a2",
urls = ["https://github.com/googleapis/gapic-generator/archive/03abac35ec0716c6f426ffc1532f9a62f1c9e6a2.zip"],
)

_rules_gapic_version = "0.5.3"
_rules_gapic_version = "0.5.4"
_maybe(
http_archive,
name = "rules_gapic",
Expand Down