-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Showcase to the latest released version, 0.16.0 #918
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1703 +95
Branches 328 347 +19
=========================================
+ Hits 1608 1703 +95
Continue to review full report at Codecov.
|
…ator-python into vchudnov-showcase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just delete the circleci configs instead of keeping them updated.
I'm very confused about the errors as well.
Yes, that works for me. |
@software-dov @busunkim96 Do these sound like spurious failures? All checks passed before merging master.... |
2d4f737
to
ab3defd
Compare
So it looks like we're failing because the generated Showcase GAPIC has 0% code coverage, I guess because it doesn't have unit tests (?). I'm confused why this wasn't a problem before this PR. Suggestions? |
Took a look at the failing CI, and I believe that the code cov failure is possibly a red herring. The tests definitely run locally, definitely run in CI, but the coverage isn't being tracked correctly. |
The update made it's way in via another PR. @vchudnov-g mind if we close this? |
Yes. let's close this, since this was done in #925 |
No description provided.