Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove duplication in grpc transport init #808

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 9, 2021

Remove duplication in the grpc and grpc_asyncio transport __init__s.

Changes:

  • rely on the base transport to set the host (adding :443 if it doesn't exist), credential, and scopes (user scopes vs. self.AUTH_SCOPES).
  • only have one call to create_channel

No behavior changes are intended.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #808 (19d3378) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #808   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1649   +41     
  Branches       328       337    +9     
=========================================
+ Hits          1608      1649   +41     
Impacted Files Coverage Δ
gapic/utils/case.py 100.00% <ø> (ø)
gapic/utils/reserved_names.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
gapic/utils/checks.py 100.00% <100.00%> (ø)
gapic/utils/options.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203cdf1...19d3378. Read the comment docs.

@busunkim96 busunkim96 marked this pull request as ready for review March 9, 2021 17:21
@busunkim96 busunkim96 requested a review from a team as a code owner March 9, 2021 17:21
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2021
@arithmetic1728 arithmetic1728 merged commit 6a2622a into master Mar 10, 2021
@arithmetic1728 arithmetic1728 deleted the simplify-init branch March 10, 2021 21:48
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants