-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag for gapic metadata #795
feat: add flag for gapic metadata #795
Conversation
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1649 +41
Branches 328 337 +9
=========================================
+ Hits 1608 1649 +41
Continue to review full report at Codecov.
|
As per the design doc, gapic metadata should not be generated by default, and should be gated by the 'metadata' flag. When invoking the generator via protoc, toggle the metadata flag like so: --python_gapic_opt="metadata" Subsequent Bazel integration is WIP.
c2e36ba
to
e0c781c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for doing this!
Before turning on the metadata file, we should resolve the issue in the other pr about the dual transports.
As per the design doc, gapic metadata should not be generated by
default, and should be gated by the 'metadata' flag.
When invoking the generator via protoc, toggle the metadata flag like so:
--python_gapic_opt="metadata"
Subsequent Bazel integration is WIP.